Ew shell#428
Merged
Merged
Conversation
feat: basic chat ui - initial commit
* feat: chat controller initial commit * feat: chat agent connection * fix: support response streaming * feat: basic markdown rendering * feat: move minimal exports of mdast from nx to nx2 * chore: code cleanup * chore: cleanup * chore: code cleanup
loadBlock now checks the providers config map before falling back to
codeBase. A block class like "ew-skills" with providers: { ew: '<url>' }
resolves to <url>/apps/skills/skills.js.
Registers the ew provider in scripts.js with env-aware origins
(localhost:3001 dev, aem.page stage, aem.live prod).
Co-authored-by: Cursor <cursoragent@cursor.com>
The + menu items now open /app?tab={skills|prompts}#/{org}/{site}/tools/skills
in a new tab, deep-linking to the correct catalog view.
Co-authored-by: Cursor <cursoragent@cursor.com>
Aligns provider block resolution with the standard EDS pattern used by nx and codeBase blocks. Co-authored-by: Cursor <cursoragent@cursor.com>
| * governing permissions and limitations under the License. | ||
| */ | ||
|
|
||
| export { loadStyle } from '../utils/style.js'; |
Member
There was a problem hiding this comment.
I would just copy the function. I'd rather have a dupe of a function than another chained request.
| } | ||
| } | ||
|
|
||
| if (isDoc && localStorage.getItem('nx-panels')) { |
Member
There was a problem hiding this comment.
Do we really want to load the panels so late? This seems like it will cause CLS.
- pathname /app → /apps/skills (mhaack) - hash drops /tools/skills suffix to match DA apps pattern (mhaack) - merge conflict resolved: drop old loadStyle re-export (now inline) and NX_BLOCKS set (provider system replaces it) Co-authored-by: Cursor <cursoragent@cursor.com>
mhaack
previously approved these changes
May 20, 2026
feat(ew): provider support reopened
mhaack
approved these changes
May 20, 2026
Contributor
mhaack
left a comment
mhaack
left a comment
There was a problem hiding this comment.
second 👍 after new changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ew-shell--da-nx--adobe.aem.page
adobe/da-live#924